Fix the input cursor position for a selection range #542
Conversation
|
Yeah, this makes sense to me. However, I can imagine some situations where the user sets the selection without the element being in focus. Then, it shouldn't display the cursor, right? I am not sure whether or not it should move focus? |
|
That is a very good point. I have not considered that the input element does not have to be focused. We could replicate what most Internet browsers do here; nothing gets selected if the element is not focused. In other words, if the cursor is not shown, |
|
Yeah, I don't see any reasonable use cases for making selection changes on non-focused elements, so that sounds good to me! Edit: I see you made a separate PR, all good :) I'll wait for that one to be merged first and then this should be good to go. |
mikke89
force-pushed
the
fix_selection_cursor_position
branch
from
7f63f2d
to
f281749
Compare
|
This one is good to go now, thanks for the PR. |
If the user of the library changes the selection range or the input cursor position, the cursor position is updated but not applied to the scrollable element. This pull request introduces a simple yet effective fix to the problem.